Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 10446084: Disable V1 auth support in remoting client and Me2Me host. (Closed)

Created:
8 years, 6 months ago by Sergey Ulanov
Modified:
3 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Disable V1 auth support in remoting client and Me2Me host. BUG=110483 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139815

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -41 lines) Patch
M remoting/client/chromoting_client.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M remoting/client/client_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/client_config.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +12 lines, -18 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sergey Ulanov
This is a subset of http://codereview.chromium.org/10453064/ that doesn't break current version of It2Me client with ...
8 years, 6 months ago (2012-05-30 18:52:05 UTC) #1
Wez
On 2012/05/30 18:52:05, sergeyu wrote: > This is a subset of http://codereview.chromium.org/10453064/ that doesn't break ...
8 years, 6 months ago (2012-05-31 00:50:49 UTC) #2
Wez
On 2012/05/31 00:50:49, Wez wrote: > On 2012/05/30 18:52:05, sergeyu wrote: > > This is ...
8 years, 6 months ago (2012-05-31 00:51:07 UTC) #3
Sergey Ulanov
On 2012/05/31 00:50:49, Wez wrote: > On 2012/05/30 18:52:05, sergeyu wrote: > > This is ...
8 years, 6 months ago (2012-05-31 01:17:53 UTC) #4
Wez
On 2012/05/31 01:17:53, sergeyu wrote: > On 2012/05/31 00:50:49, Wez wrote: > > On 2012/05/30 ...
8 years, 6 months ago (2012-05-31 01:20:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10446084/1
8 years, 6 months ago (2012-05-31 01:25:54 UTC) #6
commit-bot: I haz the power
Failed to apply patch for remoting/client/plugin/chromoting_scriptable_object.cc: While running patch -p1 --forward --force; patching file remoting/client/plugin/chromoting_scriptable_object.cc ...
8 years, 6 months ago (2012-05-31 04:45:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10446084/9002
8 years, 6 months ago (2012-05-31 08:13:26 UTC) #8
commit-bot: I haz the power
Try job failure for 10446084-9002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-05-31 10:08:52 UTC) #9
JennCook
3 years, 3 months ago (2017-08-24 23:36:49 UTC) #10
Message was sent while issue was closed.
On 2012/05/31 00:50:49, Wez wrote:
> On 2012/05/30 18:52:05, sergeyu wrote:
> > This is a subset of http://codereview.chromium.org/10453064/ that doesn't
> break
> > current version of It2Me client with newer host. With that change It2Me host
> > will be the only place left that still supports V1 authentication.
> 
> So we'll only use V1 authentication in IT2Me hosts, with older clients?  In
that
> case, could you remove the V1ClientAuthenticator implementation here?

This is the actual owner of the androids, Linux fucia, I think is what jigs
called now, was raspberry I think, I know my entire account is supports be on
hold, no one messing with anything including router and network. It hasn't
stopped. I don't know what I did to deserve this error icing attack, but it's
gone too far. Please stop changing things. I need to reinstall chrome and don't
know how.   Jenn cook

Powered by Google App Engine
This is Rietveld 408576698