Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 10446076: Handle Escape key on constrained window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/certificate_viewer.js ('k') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index ed78cfc9b83628a43443d1bac002b275655996cc..794d8191de072c40a6d44c7fc7f493208059de25 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -804,14 +804,6 @@ cr.define('print_preview', function() {
* @private
*/
onKeyDown_: function(e) {
- // Escape key closes the dialog.
- if (e.keyCode == 27 && !e.shiftKey && !e.ctrlKey && !e.altKey &&
- !e.metaKey) {
- this.close_();
- e.preventDefault();
- return;
- }
-
// Ctrl + Shift + p / Mac equivalent.
if (e.keyCode == 80) {
if ((cr.isMac && e.metaKey && e.altKey && !e.shiftKey && !e.ctrlKey) ||
« no previous file with comments | « chrome/browser/resources/certificate_viewer.js ('k') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698