Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10446062: Address review comments: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 8063)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -162,12 +162,11 @@
AddInstruction(load);
context_value = new UseVal(load);
}
- Computation* store = new StoreVMFieldComp(
+ return new StoreVMFieldComp(
context_value,
Context::variable_offset(local.index()),
value,
local.type());
- return store;
} else {
return new StoreLocalComp(local, value, owner()->context_level());
}
@@ -188,9 +187,8 @@
AddInstruction(load);
context_value = new UseVal(load);
}
- Computation* store = new LoadVMFieldComp(
+ return new LoadVMFieldComp(
context_value, Context::variable_offset(local.index()), local.type());
- return store;
} else {
return new LoadLocalComp(local, owner()->context_level());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698