Issue 10446043: Cleanup: Remove the C version of GetUrandomFD()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446043: Cleanup: Remove the C version of GetUrandomFD() (Closed)

Created:
8 years, 7 months ago by Mark Seaborn

Modified:
8 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, jochen+watch-content_chromium.org, erikwright (departed), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup: Remove the C version of GetUrandomFD() I originally added this in a #includable-from-C header so that it could be #included from NaCl-side code. However, having NaCl #include Chromium headers is not a clean interface, and this has since been replaced by runtime dependency injection. We move the function to a C++ header and put it into a namespace. Also fix the error return value for UrandomFD() so that it can't be confused with stdin. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2655 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139537

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -45 lines)			Patch
M	base/base.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/rand_util.h	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
D	base/rand_util_c.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	base/rand_util_nacl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/rand_util_posix.cc	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/nacl/nacl_listener.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/pepper/ppb_nacl_private_impl.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/common/sandbox_mac.mm	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/zygote/zygote_main_linux.cc	View	1 2	5 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

Note that I originally added this header in http://codereview.chromium.org/669055.

8 years, 6 months ago (2012-05-29 21:38:20 UTC) #1

LGTM

Expand Messages | Collapse Messages

Issue 10446043: Cleanup: Remove the C version of GetUrandomFD() (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix Mac #

Patch Set 3 : Rebase #

Patch Set 4 : Copyright #

Messages