Rename ActionBoxController -> LocationBarController.

Rename ActionBoxController -> LocationBarController.

Action box is actually the thing in the dropdown menu at the end
of the omnibox.

TBR=estade,sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139208

[Aaron Boodman, 2012-05-25 16:15:42]

Forgot to send this last night. So scattered!

[not at google - send to devlin, 2012-05-25 22:29:48]

lgtm but read my comments obviously :)

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_helper.h (right):

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_helper.h:28: class
LocationBarController;
I guess we can worry about reordering stuff as we go along later. Simple sed
ftw.

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
File chrome/browser/extensions/script_badge_controller.cc (right):

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
chrome/browser/extensions/script_badge_controller.cc:89: // TODO(aa): Update
this name?
yes, we should.

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
File chrome/browser/extensions/script_badge_controller.h (right):

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
chrome/browser/extensions/script_badge_controller.h:38: //   as we bounce from
URL to URL, without any script actually being executed.
Yeah, maybe we should be showing these on load, hopefully that's possible from
the browser.

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
chrome/browser/extensions/script_badge_controller.h:40: //   it?
Won't it?  I thought it would?

My understanding is that for content_scripts the "matches" is for top-level
frames and if you specify all_frames it will apply to sub-frames.  And that for
executing scripts it's similar. I guess my understanding is wrong?

http://codereview.chromium.org/10446034/diff/9001/chrome/browser/extensions/s...
chrome/browser/extensions/script_badge_controller.h:42: //   the renderer for
whatever reason.
Yes, I've been trying to keep all the state in one place to avoid this.  The
browser seemed like it would be adequate and less corner-casey... so yeah, been
avoiding putting any state in the renderer.

[Aaron Boodman, 2012-05-26 07:42:18]

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
File chrome/browser/extensions/extension_tab_helper.h (right):

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
chrome/browser/extensions/extension_tab_helper.h:28: class
LocationBarController;
On 2012/05/25 22:29:50, kalman wrote:
> I guess we can worry about reordering stuff as we go along later. Simple sed
> ftw.

I fixed it, let me know if you see others.

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
File chrome/browser/extensions/script_badge_controller.cc (right):

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
chrome/browser/extensions/script_badge_controller.cc:89: // TODO(aa): Update
this name?
On 2012/05/25 22:29:50, kalman wrote:
> yes, we should.

Done.

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
File chrome/browser/extensions/script_badge_controller.h (right):

https://chromiumcodereview.appspot.com/10446034/diff/9001/chrome/browser/exte...
chrome/browser/extensions/script_badge_controller.h:40: //   it?
On 2012/05/25 22:29:50, kalman wrote:
> Won't it?  I thought it would?

Nope.

> My understanding is that for content_scripts the "matches" is for top-level
> frames and if you specify all_frames it will apply to sub-frames.  And that
for
> executing scripts it's similar. I guess my understanding is wrong?

Yep.

[commit-bot: I haz the power, 2012-05-26 07:42:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/10446034/11001

[commit-bot: I haz the power, 2012-05-26 07:42:49]

Presubmit check for 10446034-11001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/gtk
    chrome/browser/ui

Presubmit checks took 1.4s to calculate.