Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 10446024: Revert 138890 - Merge 138264 - Re-enable embedded identities in URLs for HTTP authentication. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1132/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction_spdy3_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 138902)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -2937,36 +2937,6 @@
EXPECT_TRUE(d.data_received().find("Cookie: got_challenged=true")
!= std::string::npos);
}
-
- // Same test as above, except this time the restart is initiated earlier
- // (without user intervention since identity is embedded in the URL).
- {
- TestNetworkDelegate network_delegate; // must outlive URLRequest
- TestURLRequestContext context(true);
- context.set_network_delegate(&network_delegate);
- context.Init();
-
- TestDelegate d;
-
- GURL::Replacements replacements;
- std::string username("user2");
- std::string password("secret");
- replacements.SetUsernameStr(username);
- replacements.SetPasswordStr(password);
- GURL url_with_identity = url_requiring_auth.ReplaceComponents(replacements);
-
- URLRequest r(url_with_identity, &d);
- r.set_context(&context);
- r.Start();
-
- MessageLoop::current()->Run();
-
- EXPECT_TRUE(d.data_received().find("user2/secret") != std::string::npos);
-
- // Make sure we sent the cookie in the restarted transaction.
- EXPECT_TRUE(d.data_received().find("Cookie: got_challenged=true")
- != std::string::npos);
- }
}
TEST_F(URLRequestTest, DelayedCookieCallback) {
« no previous file with comments | « net/http/http_network_transaction_spdy3_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698