Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 10445038: Merged r11661, r11662 into trunk branch. (Closed)

Created:
8 years, 7 months ago by danno
Modified:
8 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r11661, r11662 into trunk branch. Fix creating substring in string.replace(<global regexp>, <function>). R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/runtime.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regexp-global.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 7 months ago (2012-05-25 16:00:14 UTC) #1
Jakob Kummerow
8 years, 7 months ago (2012-05-25 16:00:42 UTC) #2
rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698