Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10445013: Moving web_socket_proxy_private into a sub-dir in api/ (Closed)

Created:
8 years, 7 months ago by vabr (Chromium)
Modified:
8 years, 7 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, altimofeev
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moving web_socket_proxy_private into a sub-dir in api/ and including it into extensions namespace. BUG=101244 TEST=ExtensionWebSocketProxyPrivateApiTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139011

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing the order of lines around end-of-header-guard #

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Yoyo, Could you please take a look at another extension API I moved into ...
8 years, 7 months ago (2012-05-24 12:43:18 UTC) #1
Yoyo Zhou
Seems reasonable. You should feel free to pick any reasonable reviewer; if they don't think ...
8 years, 7 months ago (2012-05-24 16:59:12 UTC) #2
vabr (Chromium)
Thanks, Yoyo, both for guidance on choosing reviewers, and for the review itself. I rectified ...
8 years, 7 months ago (2012-05-25 05:58:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10445013/12
8 years, 7 months ago (2012-05-25 07:56:33 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 09:15:37 UTC) #5
Change committed as 139011

Powered by Google App Engine
This is Rietveld 408576698