Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 10445009: Re-land: Use map transitions when defining accessor properties. (Closed)

Created:
8 years, 7 months ago by Sven Panne
Modified:
8 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Re-land: Use map transitions when defining accessor properties. This is basically r11496, with the following changes: * Set back pointers in maps (cherry-picked from r11528) * Fixed size calculation in CopyInsert, as proposed by mstarzinger/rossberg * DefineFastAccessor uses GetCallbackObject instead of GetValue (for __proto__) * Put the code under a new flag, which is disabled by default * Cut down the corresponding regression test * Adapted bootup memory test, we actually only need a bit more memory on 64bit without snapshots, which can easily explained by more live maps lying around. Note that the snapshot variants are back to their previous limits. Next steps: Investigate any performance degradationswith the flag enabled, and finally remove the flag when things are OK. Furthermore, GetCallbackObject should be merged into GetValue, the distinction is confusing and error-prone. Committed: https://code.google.com/p/v8/source/detail?r=11651

Patch Set 1 #

Patch Set 2 : Temporarily comment out HaveSameMapChecks #

Patch Set 3 : Enable fast accessor properties in unit test. #

Patch Set 4 : Fixed bootup memory checks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -32 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +22 lines, -1 line 0 comments Download
M src/objects.cc View 5 chunks +193 lines, -18 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A test/mjsunit/accessor-map-sharing.js View 1 2 1 chunk +176 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-128146.js View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Michael Starzinger
8 years, 7 months ago (2012-05-24 10:03:59 UTC) #1
LGTM.

Powered by Google App Engine
This is Rietveld 408576698