Issue 10444139: Proactive tweaking of window shadow code to try to fix problem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444139: Proactive tweaking of window shadow code to try to fix problem. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)

Modified:
8 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Proactive tweaking of window shadow code to try to fix problem. BUG=128049 TEST=hope this works for the reporter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140090

Patch Set 3 : leave alpha alone #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	ui/base/cocoa/underlay_opengl_hosting_window.mm	View	1 2	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/10444139/diff/2001/ui/base/cocoa/underlay_opengl_hosting_window.mm File ui/base/cocoa/underlay_opengl_hosting_window.mm (right): https://chromiumcodereview.appspot.com/10444139/diff/2001/ui/base/cocoa/underlay_opengl_hosting_window.mm#newcode127 ui/base/cocoa/underlay_opengl_hosting_window.mm:127: const CGFloat kAlphaValueJustOpaqueEnough = 0.003; Why the alpha ...

8 years, 6 months ago (2012-06-01 17:07:23 UTC) #2

Avi (use Gerrit)

More paranoia. Reporter noted just the bottom but not the sides, so I put the ...

8 years, 6 months ago (2012-06-01 17:39:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10444139/6001

8 years, 6 months ago (2012-06-01 17:40:14 UTC) #4

Change committed as 140090

Expand Messages | Collapse Messages

Issue 10444139: Proactive tweaking of window shadow code to try to fix problem. (Closed)

Description

Patch Set 1 #

Patch Set 2 : constants? #

Patch Set 3 : leave alpha alone #

Messages