Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10444139: Proactive tweaking of window shadow code to try to fix problem. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Proactive tweaking of window shadow code to try to fix problem. BUG=128049 TEST=hope this works for the reporter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140090

Patch Set 1 #

Patch Set 2 : constants? #

Total comments: 1

Patch Set 3 : leave alpha alone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ui/base/cocoa/underlay_opengl_hosting_window.mm View 1 2 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-01 16:50:19 UTC) #1
Nico
lgtm https://chromiumcodereview.appspot.com/10444139/diff/2001/ui/base/cocoa/underlay_opengl_hosting_window.mm File ui/base/cocoa/underlay_opengl_hosting_window.mm (right): https://chromiumcodereview.appspot.com/10444139/diff/2001/ui/base/cocoa/underlay_opengl_hosting_window.mm#newcode127 ui/base/cocoa/underlay_opengl_hosting_window.mm:127: const CGFloat kAlphaValueJustOpaqueEnough = 0.003; Why the alpha ...
8 years, 6 months ago (2012-06-01 17:07:23 UTC) #2
Avi (use Gerrit)
More paranoia. Reporter noted just the bottom but not the sides, so I put the ...
8 years, 6 months ago (2012-06-01 17:39:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10444139/6001
8 years, 6 months ago (2012-06-01 17:40:14 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 20:23:47 UTC) #5
Change committed as 140090

Powered by Google App Engine
This is Rietveld 408576698