Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: dart/lib/compiler/implementation/ssa/codegen.dart

Issue 10444138: Implement super store. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update test status Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/ssa/builder.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/ssa/codegen.dart
diff --git a/dart/lib/compiler/implementation/ssa/codegen.dart b/dart/lib/compiler/implementation/ssa/codegen.dart
index 44664d94087df2d54bcf4b0b3f45170daf482f32..7984e067bbe3c253b49a7c8e32c984aa33c96128 100644
--- a/dart/lib/compiler/implementation/ssa/codegen.dart
+++ b/dart/lib/compiler/implementation/ssa/codegen.dart
@@ -1440,9 +1440,16 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
} else if (superMethod.kind == ElementKind.FIELD) {
buffer.add('this.${compiler.namer.getName(superMethod)}');
} else {
- assert(superMethod.kind == ElementKind.GETTER);
- String methodName =
- compiler.namer.getterName(currentLibrary, superMethod.name);
+ assert(superMethod.kind == ElementKind.GETTER ||
+ superMethod.kind == ElementKind.SETTER);
+ String methodName;
+ if (superMethod.kind == ElementKind.GETTER) {
+ methodName =
+ compiler.namer.getterName(currentLibrary, superMethod.name);
+ } else {
+ methodName =
+ compiler.namer.setterName(currentLibrary, superMethod.name);
+ }
buffer.add('$className.prototype.$methodName.call');
visitArguments(node.inputs);
}
« no previous file with comments | « dart/lib/compiler/implementation/ssa/builder.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698