Issue 10444136: STATIC_ASSERT is not available in shared build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444136: STATIC_ASSERT is not available in shared build. (Closed)

Created:
8 years, 6 months ago by rossberg

Modified:
8 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

STATIC_ASSERT is not available in shared build. R=svenpanne@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11700

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/d8.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 6 months ago (2012-06-01 12:26:20 UTC) #2

LGTM, but IMHO we can as well remove the whole assert...

http://codereview.chromium.org/10444136/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/10444136/diff/1/src/d8.cc#newcode1023
src/d8.cc:1023: ASSERT(sizeof(char) == sizeof(uint8_t));  // NOLINT
sizeof(char) = 1 by definition, so I am not sure if we need the assertion at
all.

Expand Messages | Collapse Messages