Fix gcc 4.6 compile issues; set but unused variable and pointer/FALSE fubar.

Fix gcc 4.6 compile issues; set but unused variable and pointer/FALSE fubar.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140019

[zel, 2012-05-31 20:45:57]

lgtm

[commit-bot: I haz the power, 2012-05-31 21:16:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10444119/1

[commit-bot: I haz the power, 2012-05-31 21:41:26]

Try job failure for 10444119-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[jar (doing other things), 2012-06-01 00:42:39]

Drive by micro-suggestion...

http://codereview.chromium.org/10444119/diff/1/chrome/browser/chromeos/extern...
File chrome/browser/chromeos/external_metrics_unittest.cc (left):

http://codereview.chromium.org/10444119/diff/1/chrome/browser/chromeos/extern...
chrome/browser/chromeos/external_metrics_unittest.cc:30: num_bytes = write(fd,
value, strlen(value) + 1);
Clearly someone was thinking about checking to be sure we wrote... so what about
adding the:
EXPECT_EQ(num_bytes, ...);
after each assignment?

...or... if you wanted... you could have:
num_bytes += write(...)
on each line, and then do one big expect:
EXPECT_EQ(num_bytes, sizeof(l) + strlen(name) + strlen(value) + 2);

[Jói, 2012-06-01 09:58:31]

http://codereview.chromium.org/10444119/diff/1/chrome/browser/chromeos/extern...
File chrome/browser/chromeos/external_metrics_unittest.cc (left):

http://codereview.chromium.org/10444119/diff/1/chrome/browser/chromeos/extern...
chrome/browser/chromeos/external_metrics_unittest.cc:30: num_bytes = write(fd,
value, strlen(value) + 1);
On 2012/06/01 00:42:39, jar wrote:
> Clearly someone was thinking about checking to be sure we wrote... so what
about
> adding the:
> EXPECT_EQ(num_bytes, ...);
> after each assignment?
> 
> ...or... if you wanted... you could have:
> num_bytes += write(...)
> on each line, and then do one big expect:
> EXPECT_EQ(num_bytes, sizeof(l) + strlen(name) + strlen(value) + 2);

Done.

[commit-bot: I haz the power, 2012-06-01 10:09:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10444119/3003

[commit-bot: I haz the power, 2012-06-01 12:32:22]

Change committed as 140019