Issue 10444113: Fixed the dependency.

Issue 10444113: Fixed the dependency. (Closed)

Created:
8 years, 6 months ago by michaelbai

Modified:
8 years, 6 months ago

Reviewers:
John Grabowski, Yaron, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, Yaron, no sievers

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed the dependency. - Moved the content_jni_registrar.{h|cc} and library_loader_hooks.cc to content/app/android/ - Moved the android_library_loader_hooks.h to content/public/app/ Those files execute the common tasks for all processes and should belong to content/app/. BUG= TEST= TBR=jrg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140062

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix header guard #

Patch Set 3 : Sync #

Patch Set 4 : Sync again #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -188 lines)			Patch
A	content/app/android/OWNERS	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A +	content/app/android/content_jni_registrar.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/app/android/content_jni_registrar.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/app/android/library_loader_hooks.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
D	content/browser/android/content_jni_registrar.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	content/browser/android/content_jni_registrar.cc	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	content/browser/android/library_loader_hooks.cc	View	1 2	1 chunk	+0 lines, -104 lines	0 comments	Download
M	content/content_app.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View		2 chunks	+0 lines, -4 lines	0 comments	Download
A +	content/public/app/android_library_loader_hooks.h	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
D	content/public/browser/android_library_loader_hooks.h	View	1 2	1 chunk	+0 lines, -22 lines	0 comments	Download
M	content/shell/android/shell_library_loader.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm assuming checkdeps passes locally https://chromiumcodereview.appspot.com/10444113/diff/1/content/public/app/android_library_loader_hooks.h File content/public/app/android_library_loader_hooks.h (left): https://chromiumcodereview.appspot.com/10444113/diff/1/content/public/app/android_library_loader_hooks.h#oldcode5 content/public/app/android_library_loader_hooks.h:5: #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_LIBRARY_LOADER_HOOKS_H_ Update header

8 years, 6 months ago (2012-05-31 18:48:47 UTC) #2

michaelbai

Yes, it passed checkdeps https://chromiumcodereview.appspot.com/10444113/diff/1/content/public/app/android_library_loader_hooks.h File content/public/app/android_library_loader_hooks.h (left): https://chromiumcodereview.appspot.com/10444113/diff/1/content/public/app/android_library_loader_hooks.h#oldcode5 content/public/app/android_library_loader_hooks.h:5: #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_LIBRARY_LOADER_HOOKS_H_ On 2012/05/31 18:48:47, ...

8 years, 6 months ago (2012-05-31 18:59:02 UTC) #3

jam

anything in content/public needs to be in the content namespace, see http://codereview.chromium.org/10440106/ which is in ...

8 years, 6 months ago (2012-05-31 23:13:38 UTC) #4