Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 10444100: Implements a focus manager for the extensions page. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebased Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 81096b8bcb00111ba7d93614e7604e063df00325..bfcf3e88d200db96a90e2eb29cb0e9d333fae09f 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -5,6 +5,7 @@
<include src="../shared/js/cr/ui/drag_wrapper.js"></include>
<include src="../uber/uber_utils.js"></include>
<include src="extension_commands_overlay.js"></include>
+<include src="extension_focus_manager.js"></include>
<include src="extension_list.js"></include>
<include src="pack_extension_overlay.js"></include>
@@ -113,6 +114,8 @@ cr.define('extensions', function() {
extensionCommandsOverlay.initializePage();
cr.ui.overlay.setupOverlay($('dropTargetOverlay'));
+
+ extensions.ExtensionFocusManager.getInstance().initialize();
},
/**
@@ -259,14 +262,21 @@ cr.define('extensions', function() {
}
/**
+ * Returns the current overlay or null if one does not exist.
+ * @return {Element} The overlay element.
+ */
+ ExtensionSettings.getCurrentOverlay = function() {
+ return document.querySelector('#overlay .page.showing');
+ }
+
+ /**
* Sets the given overlay to show. This hides whatever overlay is currently
* showing, if any.
* @param {HTMLElement} node The overlay page to show. If falsey, all overlays
* are hidden.
*/
ExtensionSettings.showOverlay = function(node) {
- var currentlyShowingOverlay =
- document.querySelector('#overlay .page.showing');
+ var currentlyShowingOverlay = ExtensionSettings.getCurrentOverlay();
if (currentlyShowingOverlay)
currentlyShowingOverlay.classList.remove('showing');
« no previous file with comments | « chrome/browser/resources/extensions/extensions.html ('k') | chrome/browser/resources/shared/js/cr/ui/overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698