Issue 10444100: Implements a focus manager for the extensions page.

Issue 10444100: Implements a focus manager for the extensions page. (Closed)

Created:
8 years, 6 months ago by Kyle Horimoto

Modified:
8 years, 6 months ago

Reviewers:
dmazzoni, Evan Stade

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Implements a focus manager for the extensions page. BUG=130374 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140156

Patch Set 2 : Changed getFocusParent() to a public function. #

Total comments: 2

Patch Set 3 : Changed documentation and simplified return statement #

Patch Set 4 : Rebased #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -23 lines)			Patch
A	chrome/browser/resources/extensions/extension_focus_manager.js	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/extensions/extensions.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/extensions/extensions.js	View	1 2	3 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/overlay.js	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

awesome. lgtm http://codereview.chromium.org/10444100/diff/3001/chrome/browser/resources/extensions/extension_focus_manager.js File chrome/browser/resources/extensions/extension_focus_manager.js (right): http://codereview.chromium.org/10444100/diff/3001/chrome/browser/resources/extensions/extension_focus_manager.js#newcode23 chrome/browser/resources/extensions/extension_focus_manager.js:23: return overlay ? overlay : $('extension-settings'); you ...

8 years, 6 months ago (2012-05-31 17:02:00 UTC) #2

Kyle Horimoto

http://codereview.chromium.org/10444100/diff/3001/chrome/browser/resources/extensions/extension_focus_manager.js File chrome/browser/resources/extensions/extension_focus_manager.js (right): http://codereview.chromium.org/10444100/diff/3001/chrome/browser/resources/extensions/extension_focus_manager.js#newcode23 chrome/browser/resources/extensions/extension_focus_manager.js:23: return overlay ? overlay : $('extension-settings'); On 2012/05/31 17:02:00, ...

8 years, 6 months ago (2012-06-01 00:02:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10444100/9001

8 years, 6 months ago (2012-06-01 20:43:55 UTC) #4

commit-bot: I haz the power

Try job failure for 10444100-9001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 6 months ago (2012-06-01 21:03:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10444100/9001

8 years, 6 months ago (2012-06-01 22:00:10 UTC) #6

Change committed as 140156

Expand Messages | Collapse Messages