Refresh drive file system metadata for entries in search results.

chrome/browser/chromeos/gdata/gdata_files_unittest.cc

Index: chrome/browser/chromeos/gdata/gdata_files_unittest.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_files_unittest.cc b/chrome/browser/chromeos/gdata/gdata_files_unittest.cc
index a161491e3a451665f2360cc5dcc89709777d2b82..d7c6fdf2f1bb45bb16eeea5491426ffd61c01a58 100644
--- a/chrome/browser/chromeos/gdata/gdata_files_unittest.cc
+++ b/chrome/browser/chromeos/gdata/gdata_files_unittest.cc
@@ -71,6 +71,41 @@ TEST(GDataRootDirectoryTest, ParseFromString_DetectBadResourceID) {
   EXPECT_EQ(kGDataRootDirectoryResourceId, root.resource_id());
 }
 
+TEST(GDataRootDirectoryTest, RefreshFile) {
+  GDataRootDirectory root;
+  // Add a directory to the file system.
+  GDataDirectory* directory_entry = new GDataDirectory(&root, &root);
+  directory_entry->set_resource_id("folder:directory_resource_id");
+  root.AddEntry(directory_entry);
+
+  // Add a new file to the directory.
+  GDataFile* initial_file_entry = new GDataFile(NULL, &root);
+  initial_file_entry->set_resource_id("file:file_resource_id");

[satorux1, 2012/05/31 20:36:18]

it's a bit more interesting to set a thumbnail URL, and replace it with the new
file entry.

[tbarzic, 2012/05/31 20:56:33]

I don't see why. We test that, after RefreshEntry, root directory returns
new_file_entry when we query for "file:file_resource_id". So, all metadata (not
just thumbnail url) we get from the file system for the given resource id will
come from the new entry.

I'm not sure that we have to check that thumbnail url specifically has changed.
Or am I missing something?

[satorux1, 2012/05/31 21:44:17]

You confirm that the file is replaced by:

ASSERT_EQ(new_file_entry, root.GetEntryByResourceId("file:file_resource_id"));

This is comparing a pointer, which is good enough, but I'm not good at
understanding abstract things like pointers, so I thought it'd be easier to
understand if we also compare thumbnail URLs. However, I think it's unnecessary

+  directory_entry->AddEntry(initial_file_entry);
+  ASSERT_EQ(directory_entry, initial_file_entry->parent());
+
+  // Initial file system state set, let's try refreshing entries.
+
+  // New value for the entry with resource id "file:file_resource_id".
+  GDataFile* new_file_entry = new GDataFile(NULL, &root);
+  new_file_entry->set_resource_id("file:file_resource_id");
+  root.RefreshFile(scoped_ptr<GDataFile>(new_file_entry).Pass());
+  // Root should have |new_file_entry|, not |initial_file_entry|.
+  // If this is not true, |new_file_entry| has probably been destroyed, hence
+  // ASSERT (we're trying to access |new_file_entry| later on).
+  ASSERT_EQ(new_file_entry, root.GetEntryByResourceId("file:file_resource_id"));
+  // We have just verified new_file_entry exists inside root, so accessing
+  // |new_file_entry->parent()| should be safe.
+  EXPECT_EQ(directory_entry, new_file_entry->parent());
+
+  // Let's try refreshing file that didn't prviously exist.
+  GDataFile* non_existent_entry = new GDataFile(NULL, &root);
+  non_existent_entry->set_resource_id("file:does_not_exist");
+  root.RefreshFile(scoped_ptr<GDataFile>(non_existent_entry).Pass());
+  // File with non existent resource id should not be added.
+  EXPECT_FALSE(root.GetEntryByResourceId("file:does_not_exist"));
+}
+
 TEST(GDataRootDirectoryTest, GetEntryByResourceId_RootDirectory) {
   GDataRootDirectory root;
   // Look up the root directory by its resource ID.