Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: runtime/lib/isolate.cc

Issue 10444069: Finalize classes before calling the main for a new isolate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/isolate.cc
===================================================================
--- runtime/lib/isolate.cc (revision 8073)
+++ runtime/lib/isolate.cc (working copy)
@@ -121,7 +121,7 @@
StartIsolateScope start_scope(isolate);
Zone zone(isolate);
HandleScope handle_scope(isolate);
- ASSERT(ClassFinalizer::FinalizePendingClasses());
+ ASSERT(ClassFinalizer::AllClassesFinalized());
// Lookup the target class by name, create an instance and call the run
// method.
const String& lib_name = String::Handle(String::NewSymbol(library_url));
@@ -549,7 +549,10 @@
StartIsolateScope start_scope(isolate);
Zone zone(isolate);
HandleScope handle_scope(isolate);
- ASSERT(ClassFinalizer::FinalizePendingClasses());
+ if (!ClassFinalizer::FinalizePendingClasses()) {
+ // Error is in sticky error already.
+ return false;
+ }
Object& result = Object::Handle();
result = state->ResolveFunction();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698