Use chrome_html structure for shared_resources and options2 page.

Use chrome_html structure for shared_resources and options2 page.

This will automatically pull in high DPI theme resources and locally available high DPI webui resources.

BUG=130124
TEST=Theme resources are referenced using @2x when running with scale factor 2.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140355

[flackr, 2012-05-31 17:50:46]

Hi James,

The grit changes to detect and insert high DPI images have landed and the
chrome_html structure should behave the same as the include node otherwise. With
this change we will insert 2x references on chromeos WebUI. PTAL, thanks!

-Rob

[flackr, 2012-05-31 17:56:07]

+joi

[Jói, 2012-05-31 18:01:52]

LGTM, nice to see this sailing into harbor.

[flackr, 2012-06-01 22:20:32]

James, ping.

[James Hawkins, 2012-06-01 23:05:57]

http://codereview.chromium.org/10444060/diff/2001/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

http://codereview.chromium.org/10444060/diff/2001/tools/gritsettings/resource...
tools/gritsettings/resource_ids:169: "structures": [22200],
Why are these called structures?

[flackr, 2012-06-04 12:11:50]

http://codereview.chromium.org/10444060/diff/2001/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

http://codereview.chromium.org/10444060/diff/2001/tools/gritsettings/resource...
tools/gritsettings/resource_ids:169: "structures": [22200],
On 2012/06/01 23:05:57, James Hawkins wrote:
> Why are these called structures?

Joi has informed me that when we are doing modification of the source (even
things like flatten_html) we should be using structure nodes and add a gatherer
type, includes should be strictly included files. As such, chrome_html is
implemented as a gatherer for a structure which performs the functions include
does and adds high dpi images.

[James Hawkins, 2012-06-04 15:18:58]

OK. LGTM

[commit-bot: I haz the power, 2012-06-04 17:27:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/10444060/14001

[commit-bot: I haz the power, 2012-06-04 20:10:31]

Change committed as 140355