Issue 10444056: Remove skia_test_expectations added in http://crrev.com/138307

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444056: Remove skia_test_expectations added in http://crrev.com/138307 (Closed)

Created:
8 years, 6 months ago by epoger

Modified:
8 years, 6 months ago

Reviewers:
tomhudson, bsalomon, reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove skia_test_expectations added in http://crrev.com/138307 control group is https://chromiumcodereview.appspot.com/10449050 BUG=129184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139302

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	skia/skia_test_expectations.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

epoger

I decided that only the subset of trybots now listed in http://skia.googlecode.com/svn/trunk/trybots_to_run/layout were important, so ...

8 years, 6 months ago (2012-05-29 15:39:09 UTC) #1

bsalomon

8 years, 6 months ago (2012-05-29 16:19:40 UTC) #2

On 2012/05/29 15:39:09, epoger wrote:
> I decided that only the subset of trybots now listed in
> http://skia.googlecode.com/svn/trunk/trybots_to_run/layout were important, so
I
> only evaluated those... and they look good to me.  L G T Y?  (first LG wins)
> 
> linux_gpu : 4 new gpu_test failures, but they are a set that often flake
> together
> linux_layout : no new failures
> linux_layout_rel : no new failures
> 
> mac_gpu : green
> mac_layout : no new failures
> mac_layout_rel : green
> 
> win_gpu : green
> win_layout : no new failures
> win_layout_rel : no new failures

LGTM

Expand Messages | Collapse Messages