Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 10444050: Show no exit instruction on Mac when in Browser Fullscreen. (Closed)

Created:
8 years, 6 months ago by scheib
Modified:
8 years, 6 months ago
Reviewers:
jeremya, jeremy
CC:
chromium-reviews
Visibility:
Public.

Description

Show no exit instruction on Mac when in Browser Fullscreen. BUG=129456 TEST=On Mac enter Browser and Tab fullscreen, e.g. with cmd-shift-f and fullscreen button in http://media.tojicode.com/q3bsp/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scheib
8 years, 6 months ago (2012-05-28 17:54:28 UTC) #1
jeremy
I think you want jeremya@ , but if you're asking me then LGTM - any ...
8 years, 6 months ago (2012-05-29 11:14:01 UTC) #2
scheib
Thanks, I had intended jeremya, adding him.
8 years, 6 months ago (2012-05-30 17:30:06 UTC) #3
scheib
Test wise, we have pretty good coverage in general for fullscreen and mouse lock now, ...
8 years, 6 months ago (2012-05-30 17:45:10 UTC) #4
jeremya
lgtm
8 years, 6 months ago (2012-05-31 23:12:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/10444050/1
8 years, 6 months ago (2012-05-31 23:39:28 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 03:38:18 UTC) #7
Try job failure for 10444050-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698