Issue 10444047: Modify Browser::IsReservedCommandOrKey() to make sure it returns false when an Ash shortcut is pres…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444047: Modify Browser::IsReservedCommandOrKey() to make sure it returns false when an Ash shortcut is pres… (Closed)

Created:
8 years, 7 months ago by Yusuke Sato

Modified:
8 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Modify Browser::IsReservedCommandOrKey() to make sure it returns false when an Ash shortcut is pressed. BUG=129978, 123856 TEST=ran unit_tests + manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139476

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	chrome/browser/ui/browser.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/browser_unittest.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10444047/3001

8 years, 6 months ago (2012-05-29 23:01:04 UTC) #3

Change committed as 139476