Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: chrome/browser/ui/browser.cc

Issue 10444040: Tracks changes to zoom icon and zoom percentage. Notifies browser window if the icon should be chan… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changed delegate to observer Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 1a27ce0c6cc48491b52a3adca51546e9f782e383..c10134ada943f55edea61c91a29b3589fca11b14 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -3707,6 +3707,26 @@ void Browser::URLStarredChanged(TabContentsWrapper* source, bool starred) {
}
///////////////////////////////////////////////////////////////////////////////
+// Browser, ZoomObserver implementation:
+
+void Browser::OnZoomIconChanged(TabContentsWrapper* source,
+ ZoomController::ZoomIconState state) {
+ if (source == GetSelectedTabContentsWrapper())
+ window_->SetZoomIconState(state);
+}
+
+void Browser::OnZoomChanged(TabContentsWrapper* source,
+ int zoom_percent) {
+ if (source == GetSelectedTabContentsWrapper()) {
+ window_->SetZoomIconTooltipPercent(zoom_percent);
+
+ // Only show the zoom bubble for zoom changes in the active window.
+ if (window_->IsActive())
+ window_->ShowZoomBubble(zoom_percent);
+ }
+}
+
+///////////////////////////////////////////////////////////////////////////////
// Browser, ExtensionTabHelperDelegate implementation:
void Browser::OnDidGetApplicationInfo(TabContentsWrapper* source,
@@ -4190,6 +4210,10 @@ void Browser::UpdateCommandsForTabState() {
// Page-related commands
window_->SetStarredState(
current_tab_wrapper->bookmark_tab_helper()->is_starred());
+ window_->SetZoomIconState(
+ current_tab_wrapper->zoom_controller()->zoom_icon_state());
+ window_->SetZoomIconTooltipPercent(
+ current_tab_wrapper->zoom_controller()->zoom_percent());
command_updater_.UpdateCommandEnabled(IDC_VIEW_SOURCE,
current_tab->GetController().CanViewSource());
command_updater_.UpdateCommandEnabled(IDC_EMAIL_PAGE_LOCATION,
@@ -4686,6 +4710,7 @@ void Browser::SetAsDelegate(TabContentsWrapper* tab, Browser* delegate) {
// ...and all the helpers.
tab->blocked_content_tab_helper()->set_delegate(delegate);
tab->bookmark_tab_helper()->set_delegate(delegate);
+ tab->zoom_controller()->set_observer(delegate);
tab->constrained_window_tab_helper()->set_delegate(delegate);
tab->core_tab_helper()->set_delegate(delegate);
tab->extension_tab_helper()->set_delegate(delegate);

Powered by Google App Engine
This is Rietveld 408576698