Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 10444039: Revert 139125 - Switch use_canvas_skia=1 for Linux/GTK. (Closed)

Created:
8 years, 7 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 139125 - Switch use_canvas_skia=1 for Linux/GTK. This is so we can get rid of canvas_linux.cc and start standardizing what the different canvas flags mean between platforms. BUG=105550 TEST=No visual change in Chrome UI. Review URL: https://chromiumcodereview.appspot.com/10452023 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
asargent_no_longer_on_chrome
8 years, 7 months ago (2012-05-25 23:16:56 UTC) #1
asargent_no_longer_on_chrome
8 years, 7 months ago (2012-05-25 23:50:37 UTC) #2
FYI, we reverted this CL because it broke the chromium.chrome compile:

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...


http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...


The problem might be the version of libpango on the bots. From the compile
error in stdio:

18c18
< libpango1.0-0 (>= 1.20.0)
---
> libpango1.0-0 (>= 1.22.0)
Cleaning...
make: ***
[out/Release/google-chrome-unstable_21.0.1152.0-r139129_amd64.deb] Error 1
  LINK(target) out/Release/interactive_ui_tests: Finished
18c18
< libpango1.0-0 (>= 1.20.0)
---
> libpango1.0-0 (>= 1.22.0)
Cleaning...
make: *** [out/Release/google-chrome-stable_21.0.1152.0-r139129_amd64.deb]
Error 1
  TOUCH out/Release/obj.target/chrome/linux_symbols.stamp
  SOLINK_MODULE(target) out/Release/obj.target/chrome/_pyautolib.so:
Finished
  COPY out/Release/_pyautolib.so
18c18
< libpango1.0-0 (>= 1.20.0)
---
> libpango1.0-0 (>= 1.22.0)
Cleaning...
make: *** [out/Release/google-chrome-beta_21.0.1152.0-r139129_amd64.deb]
Error 1
Staging common install files in '/tmp/rpm.build.RT66Nb'...
  LINK(target) out/Release/sync_integration_tests: Finished
  TOUCH out/Release/obj.target/build/chromium_builder_tests.stamp
  TOUCH out/Release/obj.target/build/chromium_2010_builder_tests.stamp
/tmp/rpm.build.RT66Nb/usr/bin
/b/build/slave/google-chrome-rel-linux_64/build/src/out/Release
/b/build/slave/google-chrome-rel-linux_64/build/src/out/Release
Staging RPM install files in '/tmp/rpm.build.RT66Nb'...



On Fri, May 25, 2012 at 4:16 PM, <asargent@chromium.org> wrote:

> Reviewers: Alexei Svitkine,
>
> Description:
> Revert 139125 - Switch use_canvas_skia=1 for Linux/GTK.
>
> This is so we can get rid of canvas_linux.cc and start
> standardizing what the different canvas flags mean
> between platforms.
>
> BUG=105550
> TEST=No visual change in Chrome UI.
>
> Review URL:
https://chromiumcodereview.**appspot.com/10452023<https://chromiumcodereview....
>
> TBR=asvitkine@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/10444039/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 139138)
> +++ build/common.gypi   (working copy)
> @@ -499,7 +499,7 @@
>         #
>         # On Aura, this allows per-tile painting to be used in the browser
>         # compositor.
> -        ['OS!="mac" and OS!="android"', {
> +        ['use_aura==1 or OS=="win"', {
>           'use_canvas_skia%': 1,
>         }],
>       ],
>
>
>

Powered by Google App Engine
This is Rietveld 408576698