Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/ui/views/frame/browser_frame_aura.cc

Issue 10444014: ash: Improved window maximize/restore animations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix lock screen, app windows Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_frame_aura.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame_aura.cc b/chrome/browser/ui/views/frame/browser_frame_aura.cc
index 4e0205bbf5d2c030040f02d188806bae36a93bad..16eb23afbf3b5437690dd0d249c1a60c351406ac 100644
--- a/chrome/browser/ui/views/frame/browser_frame_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_frame_aura.cc
@@ -24,6 +24,8 @@
#include "ash/wm/property_util.h"
#endif
+using aura::Window;
+
////////////////////////////////////////////////////////////////////////////////
// BrowserFrameAura::WindowPropertyWatcher
@@ -83,6 +85,14 @@ BrowserFrameAura::BrowserFrameAura(BrowserFrame* browser_frame,
GetNativeWindow(),
ash::WINDOW_PERSISTS_ACROSS_ALL_WORKSPACES_VALUE_NO);
}
+ // HACK: Don't animate app windows. They delete and rebuild their frame on
+ // maximize, which breaks the layer animations. We probably shouldn't rebuild
+ // the frame view on this transition.
+ // TODO(jamescook): Fix app window animation. http://crbug.com/131293
+ if (browser_view->browser()->is_app()) {
+ Window* window = GetNativeWindow();
+ window->SetProperty(aura::client::kAnimationsDisabledKey, true);
+ }
#endif
}
« no previous file with comments | « ash/wm/workspace/workspace_manager_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698