Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10443111: Hopefully fix currently unexplainable windows failures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 #include "vm/locations.h" 9 #include "vm/locations.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 Register temp = locs()->temp(0).reg(); 67 Register temp = locs()->temp(0).reg();
68 ASSERT(result == EAX); 68 ASSERT(result == EAX);
69 if (!compiler->is_optimizing()) { 69 if (!compiler->is_optimizing()) {
70 // Count only in unoptimized code. 70 // Count only in unoptimized code.
71 // TODO(srdjan): Replace the counting code with a type feedback 71 // TODO(srdjan): Replace the counting code with a type feedback
72 // collection and counting stub. 72 // collection and counting stub.
73 const Function& function = 73 const Function& function =
74 Function::ZoneHandle(compiler->parsed_function().function().raw()); 74 Function::ZoneHandle(compiler->parsed_function().function().raw());
75 __ LoadObject(temp, function); 75 __ LoadObject(temp, function);
76 __ incl(FieldAddress(temp, Function::usage_counter_offset())); 76 __ incl(FieldAddress(temp, Function::usage_counter_offset()));
77 if (CodeGenerator::CanOptimize()) { 77 /*if (CodeGenerator::CanOptimize()) {
78 // Do not optimize if usage count must be reported. 78 // Do not optimize if usage count must be reported.
79 __ cmpl(FieldAddress(temp, Function::usage_counter_offset()), 79 __ cmpl(FieldAddress(temp, Function::usage_counter_offset()),
80 Immediate(FLAG_optimization_counter_threshold)); 80 Immediate(FLAG_optimization_counter_threshold));
81 Label not_yet_hot; 81 Label not_yet_hot;
82 __ j(LESS_EQUAL, &not_yet_hot, Assembler::kNearJump); 82 __ j(LESS_EQUAL, &not_yet_hot, Assembler::kNearJump);
83 __ pushl(result); // Preserve result. 83 __ pushl(result); // Preserve result.
84 __ pushl(temp); // Argument for runtime: function to optimize. 84 __ pushl(temp); // Argument for runtime: function to optimize.
85 __ CallRuntime(kOptimizeInvokedFunctionRuntimeEntry); 85 __ CallRuntime(kOptimizeInvokedFunctionRuntimeEntry);
86 __ popl(temp); // Remove argument. 86 __ popl(temp); // Remove argument.
87 __ popl(result); // Restore result. 87 __ popl(result); // Restore result.
88 __ Bind(&not_yet_hot); 88 __ Bind(&not_yet_hot);
89 } 89 } */
90 } 90 }
91 if (FLAG_trace_functions) { 91 if (FLAG_trace_functions) {
92 const Function& function = 92 const Function& function =
93 Function::ZoneHandle(compiler->parsed_function().function().raw()); 93 Function::ZoneHandle(compiler->parsed_function().function().raw());
94 __ LoadObject(temp, function); 94 __ LoadObject(temp, function);
95 __ pushl(result); // Preserve result. 95 __ pushl(result); // Preserve result.
96 __ pushl(temp); 96 __ pushl(temp);
97 compiler->GenerateCallRuntime(AstNode::kNoId, 97 compiler->GenerateCallRuntime(AstNode::kNoId,
98 0, 98 0,
99 CatchClauseNode::kInvalidTryIndex, 99 CatchClauseNode::kInvalidTryIndex,
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 __ movl(locs()->out().reg(), EAX); 584 __ movl(locs()->out().reg(), EAX);
585 } 585 }
586 } 586 }
587 587
588 588
589 } // namespace dart 589 } // namespace dart
590 590
591 #undef __ 591 #undef __
592 592
593 #endif // defined TARGET_ARCH_X64 593 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698