Add additional tests for mouse lock.

Add additional tests for mouse lock.

-SameMouseLockMovement
-testMouseLockLostOnReload

TEST=none
BUG=130301
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139861

[scheib, 2012-05-30 23:27:33]

lgtm

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
File chrome/test/functional/fullscreen_mouselock.py (right):

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:465: print "Press F5 key to
reload page and exit mouse lock."
Is it possible to use NavigateToURL to reproduce this bug?

[Nirnimesh, 2012-05-31 00:19:26]

Please clearly label in the docstrings that these tests are semi-automated.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
File chrome/test/functional/fullscreen_mouselock.py (right):

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:173: lambda:
self.IsMouseLockPermissionRequested()))
 lambda: self.IsMouseLockPermissionRequested() ->
self.IsMouseLockPermissionRequested

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:452: """
Comments should be comments, not strings

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:453: Manually move the mouse
cursor on the page in tab 2. Shift+Tab into
The entire string can be moved inside the raw_input. See next comment.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:457: raw_input()
Put some instructions in the raw_input() here

raw_input('Do this and that and this')

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:465: print "Press F5 key to
reload page and exit mouse lock."
print -> logging.info

or better still use raw_input() instead of sleep

[dyu1, 2012-05-31 01:09:16]

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
File chrome/test/functional/fullscreen_mouselock.py (right):

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:173: lambda:
self.IsMouseLockPermissionRequested()))
On 2012/05/31 00:19:26, Nirnimesh wrote:
>  lambda: self.IsMouseLockPermissionRequested() ->
> self.IsMouseLockPermissionRequested

Done.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:452: """
On 2012/05/31 00:19:26, Nirnimesh wrote:
> Comments should be comments, not strings

Done.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:453: Manually move the mouse
cursor on the page in tab 2. Shift+Tab into
On 2012/05/31 00:19:26, Nirnimesh wrote:
> The entire string can be moved inside the raw_input. See next comment.

Done.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:457: raw_input()
On 2012/05/31 00:19:26, Nirnimesh wrote:
> Put some instructions in the raw_input() here
> 
> raw_input('Do this and that and this')

Done.

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:465: print "Press F5 key to
reload page and exit mouse lock."
I used NavigateToURL on line 461. Is that what you were asking?

On 2012/05/30 23:27:33, scheib wrote:
> Is it possible to use NavigateToURL to reproduce this bug?

http://codereview.chromium.org/10443098/diff/2001/chrome/test/functional/full...
chrome/test/functional/fullscreen_mouselock.py:465: print "Press F5 key to
reload page and exit mouse lock."
On 2012/05/31 00:19:26, Nirnimesh wrote:
> print -> logging.info
> 
> or better still use raw_input() instead of sleep

I can't use raw_input() here since when the mouse locks I can't focus away from
the window for the test to work the way it's intended.

[Nirnimesh, 2012-05-31 01:54:11]

LGTM

[dyu1, 2012-05-31 17:54:54]

I converted mouse lock break on page reload to a full test using
ReloadActiveTab().

[Nirnimesh, 2012-05-31 18:09:53]

LGTM still.
Please disable the new test and also testMouseLockInBrowserFS on chromeos.

[scheib, 2012-05-31 18:13:09]

lgtm