Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
index 0c25687a7495d0adcab82e147e3e8ffe4580723b..784331a3cf4c05209828b374687fac347c0b38c3 100644
--- a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
@@ -27,7 +27,7 @@
ShellWindowCocoa::ShellWindowCocoa(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params)
+ const ShellWindow::CreateParams& params)
: ShellWindow(profile, extension, url),
attention_request_id_(0) {
NSRect rect = NSMakeRect(params.bounds.x(), params.bounds.y(),
@@ -177,6 +177,6 @@ NSWindow* ShellWindowCocoa::window() const {
ShellWindow* ShellWindow::CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
return new ShellWindowCocoa(profile, extension, url, params);
}
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h ('k') | chrome/browser/ui/extensions/shell_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698