Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10443068: Add APK targets for sql_unittests and sync_unit_tests. (Closed)

Created:
8 years, 6 months ago by nilesh
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add APK targets for sql_unittests and sync_unit_tests. BUG=125059 Follow-up to: http://codereview.chromium.org/10399126/ TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139727

Patch Set 1 #

Patch Set 2 : ninja build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M sql/sql.gyp View 1 2 chunks +28 lines, -1 line 0 comments Download
M sync/sync.gyp View 1 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
@tim: Please look at sync/ @shess: Please look at sql/
8 years, 6 months ago (2012-05-29 22:37:35 UTC) #1
Scott Hess - ex-Googler
lgtm for sql. [LGTM entirely based on more knowledgeable people previous LGTM'ing more complicated stuff...]
8 years, 6 months ago (2012-05-29 22:59:01 UTC) #2
John Grabowski
LGTM
8 years, 6 months ago (2012-05-30 00:18:44 UTC) #3
tim (not reviewing)
lgtm
8 years, 6 months ago (2012-05-30 22:41:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10443068/6001
8 years, 6 months ago (2012-05-30 22:42:34 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 04:36:22 UTC) #6 
Change committed as 139727

Powered by Google App Engine
This is Rietveld 408576698