Issue 10443054: roll gyp 1397:1402

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10443054: roll gyp 1397:1402 (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll gyp 1397:1402 1398: mac ninja/make: Cache _sdk_base_dir at class level; 12s faster. 1399: mac ninja/make: Cache topological sort; 2.5s faster 1400: Remove slow debug statement, 3s faster (all generators) 1401: Update golden files after r1400. In total, ninja/mac gyp time 45s -> 28s on my machine. BUG=82230 TEST=none TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139270

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10443054/1

8 years, 6 months ago (2012-05-28 22:36:46 UTC) #2

nice! lgtm

Expand Messages | Collapse Messages