Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 10443052: Fix missing write barrier in store field stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 __ li(a2, Operand(transition)); 451 __ li(a2, Operand(transition));
452 __ Push(a2, a0); 452 __ Push(a2, a0);
453 __ TailCallExternalReference( 453 __ TailCallExternalReference(
454 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage), 454 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
455 masm->isolate()), 455 masm->isolate()),
456 3, 1); 456 3, 1);
457 return; 457 return;
458 } 458 }
459 459
460 if (!transition.is_null()) { 460 if (!transition.is_null()) {
461 // Update the map of the object; no write barrier updating is 461 // Update the map of the object.
462 // needed because the map is never in new space. 462 __ li(scratch, Operand(transition));
463 __ li(t0, Operand(transition)); 463 __ sw(scratch, FieldMemOperand(receiver_reg, HeapObject::kMapOffset));
464 __ sw(t0, FieldMemOperand(receiver_reg, HeapObject::kMapOffset)); 464
465 // Update the write barrier for the map field and pass the now unused
466 // name_reg as scratch register.
467 __ RecordWriteField(receiver_reg,
468 HeapObject::kMapOffset,
469 scratch,
470 name_reg,
471 kRAHasNotBeenSaved,
472 kDontSaveFPRegs,
473 OMIT_REMEMBERED_SET,
474 OMIT_SMI_CHECK);
465 } 475 }
466 476
467 // Adjust for the number of properties stored in the object. Even in the 477 // Adjust for the number of properties stored in the object. Even in the
468 // face of a transition we can use the old map here because the size of the 478 // face of a transition we can use the old map here because the size of the
469 // object and the number of in-object properties is not going to change. 479 // object and the number of in-object properties is not going to change.
470 index -= object->map()->inobject_properties(); 480 index -= object->map()->inobject_properties();
471 481
472 if (index < 0) { 482 if (index < 0) {
473 // Set the property straight into the object. 483 // Set the property straight into the object.
474 int offset = object->map()->instance_size() + (index * kPointerSize); 484 int offset = object->map()->instance_size() + (index * kPointerSize);
(...skipping 4116 matching lines...) Expand 10 before | Expand all | Expand 10 after
4591 __ Jump(ic_slow, RelocInfo::CODE_TARGET); 4601 __ Jump(ic_slow, RelocInfo::CODE_TARGET);
4592 } 4602 }
4593 } 4603 }
4594 4604
4595 4605
4596 #undef __ 4606 #undef __
4597 4607
4598 } } // namespace v8::internal 4608 } } // namespace v8::internal
4599 4609
4600 #endif // V8_TARGET_ARCH_MIPS 4610 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698