Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: src/mips/lithium-mips.h

Issue 10443052: Fix missing write barrier in store field stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1643 1643
1644 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag") 1644 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag")
1645 1645
1646 bool needs_check() const { return needs_check_; } 1646 bool needs_check() const { return needs_check_; }
1647 1647
1648 private: 1648 private:
1649 bool needs_check_; 1649 bool needs_check_;
1650 }; 1650 };
1651 1651
1652 1652
1653 class LStoreNamedField: public LTemplateInstruction<0, 2, 0> { 1653 class LStoreNamedField: public LTemplateInstruction<0, 2, 1> {
1654 public: 1654 public:
1655 LStoreNamedField(LOperand* obj, LOperand* val) { 1655 LStoreNamedField(LOperand* obj, LOperand* val, LOperand* temp) {
1656 inputs_[0] = obj; 1656 inputs_[0] = obj;
1657 inputs_[1] = val; 1657 inputs_[1] = val;
1658 temps_[0] = temp;
1658 } 1659 }
1659 1660
1660 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field") 1661 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field")
1661 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField) 1662 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField)
1662 1663
1663 virtual void PrintDataTo(StringStream* stream); 1664 virtual void PrintDataTo(StringStream* stream);
1664 1665
1665 LOperand* object() { return inputs_[0]; } 1666 LOperand* object() { return inputs_[0]; }
1666 LOperand* value() { return inputs_[1]; } 1667 LOperand* value() { return inputs_[1]; }
1667 1668
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
2395 2396
2396 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2397 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2397 }; 2398 };
2398 2399
2399 #undef DECLARE_HYDROGEN_ACCESSOR 2400 #undef DECLARE_HYDROGEN_ACCESSOR
2400 #undef DECLARE_CONCRETE_INSTRUCTION 2401 #undef DECLARE_CONCRETE_INSTRUCTION
2401 2402
2402 } } // namespace v8::internal 2403 } } // namespace v8::internal
2403 2404
2404 #endif // V8_MIPS_LITHIUM_MIPS_H_ 2405 #endif // V8_MIPS_LITHIUM_MIPS_H_
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698