Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-ia32.h

Issue 10443052: Fix missing write barrier in store field stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1697 matching lines...) Expand 10 before | Expand all | Expand 10 after
1708 1708
1709 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag") 1709 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag")
1710 1710
1711 bool needs_check() const { return needs_check_; } 1711 bool needs_check() const { return needs_check_; }
1712 1712
1713 private: 1713 private:
1714 bool needs_check_; 1714 bool needs_check_;
1715 }; 1715 };
1716 1716
1717 1717
1718 class LStoreNamedField: public LTemplateInstruction<0, 2, 1> { 1718 class LStoreNamedField: public LTemplateInstruction<0, 2, 2> {
1719 public: 1719 public:
1720 LStoreNamedField(LOperand* obj, LOperand* val, LOperand* temp) { 1720 LStoreNamedField(LOperand* obj,
1721 LOperand* val,
1722 LOperand* temp,
1723 LOperand* temp_map) {
1721 inputs_[0] = obj; 1724 inputs_[0] = obj;
1722 inputs_[1] = val; 1725 inputs_[1] = val;
1723 temps_[0] = temp; 1726 temps_[0] = temp;
1727 temps_[1] = temp_map;
1724 } 1728 }
1725 1729
1726 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field") 1730 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field")
1727 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField) 1731 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField)
1728 1732
1729 virtual void PrintDataTo(StringStream* stream); 1733 virtual void PrintDataTo(StringStream* stream);
1730 1734
1731 LOperand* object() { return inputs_[0]; } 1735 LOperand* object() { return inputs_[0]; }
1732 LOperand* value() { return inputs_[1]; } 1736 LOperand* value() { return inputs_[1]; }
1733 1737
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
2516 2520
2517 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2521 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2518 }; 2522 };
2519 2523
2520 #undef DECLARE_HYDROGEN_ACCESSOR 2524 #undef DECLARE_HYDROGEN_ACCESSOR
2521 #undef DECLARE_CONCRETE_INSTRUCTION 2525 #undef DECLARE_CONCRETE_INSTRUCTION
2522 2526
2523 } } // namespace v8::internal 2527 } } // namespace v8::internal
2524 2528
2525 #endif // V8_IA32_LITHIUM_IA32_H_ 2529 #endif // V8_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698