Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: src/hydrogen-instructions.h

Issue 10443052: Fix missing write barrier in store field stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4180 matching lines...) Expand 10 before | Expand all | Expand 10 after
4191 int offset() const { return offset_; } 4191 int offset() const { return offset_; }
4192 Handle<Map> transition() const { return transition_; } 4192 Handle<Map> transition() const { return transition_; }
4193 void set_transition(Handle<Map> map) { transition_ = map; } 4193 void set_transition(Handle<Map> map) { transition_ = map; }
4194 HValue* new_space_dominator() const { return new_space_dominator_; } 4194 HValue* new_space_dominator() const { return new_space_dominator_; }
4195 4195
4196 bool NeedsWriteBarrier() { 4196 bool NeedsWriteBarrier() {
4197 return StoringValueNeedsWriteBarrier(value()) && 4197 return StoringValueNeedsWriteBarrier(value()) &&
4198 ReceiverObjectNeedsWriteBarrier(object(), new_space_dominator()); 4198 ReceiverObjectNeedsWriteBarrier(object(), new_space_dominator());
4199 } 4199 }
4200 4200
4201 bool NeedsWriteBarrierForMap() {
4202 return ReceiverObjectNeedsWriteBarrier(object(), new_space_dominator());
4203 }
4204
4201 private: 4205 private:
4202 Handle<String> name_; 4206 Handle<String> name_;
4203 bool is_in_object_; 4207 bool is_in_object_;
4204 int offset_; 4208 int offset_;
4205 Handle<Map> transition_; 4209 Handle<Map> transition_;
4206 HValue* new_space_dominator_; 4210 HValue* new_space_dominator_;
4207 }; 4211 };
4208 4212
4209 4213
4210 class HStoreNamedGeneric: public HTemplateInstruction<3> { 4214 class HStoreNamedGeneric: public HTemplateInstruction<3> {
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
5053 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex); 5057 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex);
5054 }; 5058 };
5055 5059
5056 5060
5057 #undef DECLARE_INSTRUCTION 5061 #undef DECLARE_INSTRUCTION
5058 #undef DECLARE_CONCRETE_INSTRUCTION 5062 #undef DECLARE_CONCRETE_INSTRUCTION
5059 5063
5060 } } // namespace v8::internal 5064 } } // namespace v8::internal
5061 5065
5062 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 5066 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698