Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: src/arm/lithium-arm.h

Issue 10443052: Fix missing write barrier in store field stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1666 matching lines...) Expand 10 before | Expand all | Expand 10 after
1677 1677
1678 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag") 1678 DECLARE_CONCRETE_INSTRUCTION(SmiUntag, "smi-untag")
1679 1679
1680 bool needs_check() const { return needs_check_; } 1680 bool needs_check() const { return needs_check_; }
1681 1681
1682 private: 1682 private:
1683 bool needs_check_; 1683 bool needs_check_;
1684 }; 1684 };
1685 1685
1686 1686
1687 class LStoreNamedField: public LTemplateInstruction<0, 2, 0> { 1687 class LStoreNamedField: public LTemplateInstruction<0, 2, 1> {
1688 public: 1688 public:
1689 LStoreNamedField(LOperand* obj, LOperand* val) { 1689 LStoreNamedField(LOperand* obj, LOperand* val, LOperand* temp) {
1690 inputs_[0] = obj; 1690 inputs_[0] = obj;
1691 inputs_[1] = val; 1691 inputs_[1] = val;
1692 temps_[0] = temp;
1692 } 1693 }
1693 1694
1694 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field") 1695 DECLARE_CONCRETE_INSTRUCTION(StoreNamedField, "store-named-field")
1695 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField) 1696 DECLARE_HYDROGEN_ACCESSOR(StoreNamedField)
1696 1697
1697 virtual void PrintDataTo(StringStream* stream); 1698 virtual void PrintDataTo(StringStream* stream);
1698 1699
1699 LOperand* object() { return inputs_[0]; } 1700 LOperand* object() { return inputs_[0]; }
1700 LOperand* value() { return inputs_[1]; } 1701 LOperand* value() { return inputs_[1]; }
1701 1702
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
2432 2433
2433 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2434 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2434 }; 2435 };
2435 2436
2436 #undef DECLARE_HYDROGEN_ACCESSOR 2437 #undef DECLARE_HYDROGEN_ACCESSOR
2437 #undef DECLARE_CONCRETE_INSTRUCTION 2438 #undef DECLARE_CONCRETE_INSTRUCTION
2438 2439
2439 } } // namespace v8::internal 2440 } } // namespace v8::internal
2440 2441
2441 #endif // V8_ARM_LITHIUM_ARM_H_ 2442 #endif // V8_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698