Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10443047: Disable synchronous XMLHttpRequests in platform app documents. (Closed)

Created:
8 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Disable synchronous XMLHttpRequests in platform app documents. Depends on http://webkit.org/b/87540 R=darin@chromium.org BUG=130185 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M chrome/browser/extensions/extension_webkit_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/test.js View 2 chunks +11 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mihai Parparita -not on Chrome
8 years, 7 months ago (2012-05-25 23:33:11 UTC) #1
darin (slow to review)
LGTM
8 years, 7 months ago (2012-05-25 23:59:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10443047/1
8 years, 6 months ago (2012-05-29 17:18:33 UTC) #3
commit-bot: I haz the power
Try job failure for 10443047-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 6 months ago (2012-05-29 17:32:09 UTC) #4
Mihai Parparita -not on Chrome
Oops, I misread DEPS; http://trac.webkit.org/changeset/118599 hasn't been picked up by a roll yet. Mihai On ...
8 years, 6 months ago (2012-05-29 17:40:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10443047/1
8 years, 6 months ago (2012-05-30 16:37:57 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 21:22:10 UTC) #7
Change committed as 139637

Powered by Google App Engine
This is Rietveld 408576698