Silent mouse lock after unlock by target

chrome/browser/ui/browser.h

Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 46ba61cd7af8162c330ab1cd451aa825a901b08f..d72a406a9cc612968cbcf0f11f355fe3551619c3 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -43,6 +43,7 @@
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_types.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "content/common/mouse_lock.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/web_contents_delegate.h"
@@ -986,8 +987,10 @@ class Browser : public TabStripModelDelegate,
                          int active_match_ordinal,
                          bool final_update) OVERRIDE;
 
-  virtual void RequestToLockMouse(content::WebContents* tab,
-                                  bool user_gesture) OVERRIDE;
+  virtual void RequestToLockMouse(
+      content::WebContents* tab,
+      content::MouseLockSource lock_source,

[scheib, 2012/05/30 16:41:21]

Comment: This naming has become unfortunately abstract now. Previously it was
quite clear, user_gesture == true or false. Now it's the mouse lock source... is
that the source UI element, or the requesting source, or... oh, after finding
the file with enum values I see it's user gesture related. Essentially we trade
the readability of the single point of value specification vs the readability
through all the methods that pass/receive the parameter. Off hand I haven't
thought of a better enum name that indicates it's user gesture related, but give
it a shot.

+      content::MouseUnlockSource previous_unlock_source) OVERRIDE;
   virtual void LostMouseLock() OVERRIDE;
 
   // Overridden from CoreTabHelperDelegate: