Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 10443021: Android: Get the cache directory using path service. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski, dmac
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Android: Get the cache directory using path service. "/data/local" is not writable on non-rooted devices and while running tests in an APK. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138981

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 1 10 chunks +28 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nilesh
8 years, 7 months ago (2012-05-24 21:37:52 UTC) #1
John Grabowski
http://codereview.chromium.org/10443021/diff/1/ipc/ipc_channel_posix_unittest.cc File ipc/ipc_channel_posix_unittest.cc (right): http://codereview.chromium.org/10443021/diff/1/ipc/ipc_channel_posix_unittest.cc#newcode101 ipc/ipc_channel_posix_unittest.cc:101: static std::string GetConnectionSocketName(); these should return 'const std::string&'
8 years, 7 months ago (2012-05-24 21:48:17 UTC) #2
nilesh
http://codereview.chromium.org/10443021/diff/1/ipc/ipc_channel_posix_unittest.cc File ipc/ipc_channel_posix_unittest.cc (right): http://codereview.chromium.org/10443021/diff/1/ipc/ipc_channel_posix_unittest.cc#newcode101 ipc/ipc_channel_posix_unittest.cc:101: static std::string GetConnectionSocketName(); On 2012/05/24 21:48:18, John Grabowski wrote: ...
8 years, 7 months ago (2012-05-24 22:27:51 UTC) #3
dmac
lgtm
8 years, 7 months ago (2012-05-24 22:46:30 UTC) #4
John Grabowski
On 2012/05/24 22:46:30, dmac wrote: > lgtm ok then; LGTM
8 years, 7 months ago (2012-05-25 01:12:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10443021/8002
8 years, 7 months ago (2012-05-25 01:21:29 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 02:56:30 UTC) #7
Change committed as 138981

Powered by Google App Engine
This is Rietveld 408576698