Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10443013: Add support for temp locations and port Load-/StoreStaticField to use locations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/intermediate_language_x64.cc » ('j') | vm/locations.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_x64.cc
===================================================================
--- vm/flow_graph_compiler_x64.cc (revision 7955)
+++ vm/flow_graph_compiler_x64.cc (working copy)
@@ -889,15 +889,14 @@
void FlowGraphCompiler::VisitLoadStaticField(LoadStaticFieldComp* comp) {
- __ LoadObject(RDX, comp->field());
- __ movq(RAX, FieldAddress(RDX, Field::value_offset()));
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
void FlowGraphCompiler::VisitStoreStaticField(StoreStaticFieldComp* comp) {
- LoadValue(RAX, comp->value());
- __ LoadObject(RDX, comp->field());
- __ StoreIntoObject(RDX, FieldAddress(RDX, Field::value_offset()), RAX);
+ // Moved to intermediate_language_x64.cc.
+ UNREACHABLE();
}
@@ -1356,7 +1355,7 @@
locs->AllocateRegisters();
// Load instruction inputs into allocated registers.
- for (intptr_t i = locs->count() - 1; i >= 0; i--) {
+ for (intptr_t i = locs->input_count() - 1; i >= 0; i--) {
Location loc = locs->in(i);
ASSERT(loc.kind() == Location::kRegister);
__ popq(loc.reg());
« no previous file with comments | « no previous file | vm/intermediate_language_x64.cc » ('j') | vm/locations.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698