Add support for temp locations and port Load-/StoreStaticField to use locations.

vm/locations.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/locations.h"
 
 #include "vm/intermediate_language.h"
 
 namespace dart {
 
@@ skipping 12 matching lines @@
 
 
 void LocationSummary::AllocateRegisters() {
   EmbeddedArray<bool, kNumberOfCpuRegisters> blocked_registers;
 
   // Mark all available registers free.
   for (intptr_t i = 0; i < kNumberOfCpuRegisters; i++) {
     blocked_registers[i] = false;
   }
 
-  // Mark all fixed registers as used.
-  for (intptr_t i = 0; i < count(); i++) {
+  // Mark all fixed input, temp and output registers as used.
+  for (intptr_t i = 0; i < input_count(); i++) {
     Location loc = in(i);
     if (loc.kind() == Location::kRegister) {
       ASSERT(!blocked_registers[loc.reg()]);
       blocked_registers[loc.reg()] = true;
     }
   }
 
+  for (intptr_t i = 0; i < temp_count(); i++) {
+    Location loc = temp(i);
+    if (loc.kind() == Location::kRegister) {
+      ASSERT(!blocked_registers[loc.reg()]);
+      blocked_registers[loc.reg()] = true;
+    }
+  }
+
+  if (out().kind() == Location::kRegister) {
+    ASSERT(!blocked_registers[out().reg()]);
+    blocked_registers[out().reg()] = true;

[srdjan, 2012/05/24 18:57:16]

We should be able to have the same input/temp and output register, i.e., the
assert maybe wrong.

+  }
+
   // Do not allocate known registers.
   blocked_registers[CTX] = true;
   if (TMP != kNoRegister) {
     blocked_registers[TMP] = true;
   }
 
   // Allocate all unallocated input locations.
-  for (intptr_t i = 0; i < count(); i++) {
+  for (intptr_t i = 0; i < input_count(); i++) {
     Location loc = in(i);
     if (loc.kind() == Location::kUnallocated) {
       ASSERT(loc.policy() == Location::kRequiresRegister);
       set_in(i, Location::RegisterLocation(
           AllocateFreeRegister(&blocked_registers)));
     }
   }
 
+  // Allocate all unallocated temp locations.
+  for (intptr_t i = 0; i < temp_count(); i++) {
+    Location loc = temp(i);
+    if (loc.kind() == Location::kUnallocated) {
+      ASSERT(loc.policy() == Location::kRequiresRegister);
+      set_temp(i, Location::RegisterLocation(
+          AllocateFreeRegister(&blocked_registers)));
+    }
+  }
+
   Location result_location = out();
   if (result_location.kind() == Location::kUnallocated) {
     switch (result_location.policy()) {
       case Location::kRequiresRegister:
         result_location = Location::RegisterLocation(
             AllocateFreeRegister(&blocked_registers));
         break;
       case Location::kSameAsFirstInput:
         result_location = in(0);
         break;
     }
     set_out(result_location);
   }
 }
 
 
 }  // namespace dart