src/x64/stub-cache-x64.cc - Issue 10442129: Implement implicit instance checks for API accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 10442129: Implement implicit instance checks for API accessors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Daniel Clifford. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 2cfe17b5bedd60de819d6b2b3305b1b57b2f1ced..9e117d304862258ac5175344e220772572ac1394 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -1110,8 +1110,9 @@ void StubCompiler::GenerateLoadInterceptor(Handle<JSObject> object,

compile_followup_inline = true;

} else if (lookup->type() == CALLBACKS &&

lookup->GetCallbackObject()->IsAccessorInfo()) {

- compile_followup_inline =

- AccessorInfo::cast(lookup->GetCallbackObject())->getter() != NULL;

+ AccessorInfo* callback = AccessorInfo::cast(lookup->GetCallbackObject());

+ compile_followup_inline = callback->getter() != NULL &&

+ callback->IsCompatibleReceiver(*object);

}

« no previous file with comments | « src/stub-cache.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »