Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10442128: Make UI language change work on chromeos. (Closed)

Created:
8 years, 6 months ago by kochi
Modified:
8 years, 6 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Make UI language change work on chromeos. The left hand side value can't be string literal. BUG=chromium:130715 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141632

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix for comments. #

Total comments: 2

Patch Set 3 : update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/browser/resources/options2/language_options.js View 1 2 6 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kochi
Hi Evan, Dan, Could you review this? UI language change was broken since r137067. http://src.chromium.org/viewvc/chrome?view=rev&revision=137067 ...
8 years, 6 months ago (2012-06-01 07:56:28 UTC) #1
Evan Stade
sorry for breakage. LGTM https://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js File chrome/browser/resources/options2/language_options.js (left): https://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js#oldcode116 chrome/browser/resources/options2/language_options.js:116: chrome.send.bind(chrome, 'uiLanguageRestart'); is this change ...
8 years, 6 months ago (2012-06-01 17:21:16 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js File chrome/browser/resources/options2/language_options.js (right): https://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js#newcode43 chrome/browser/resources/options2/language_options.js:43: // For recording the prospective language (the next locale ...
8 years, 6 months ago (2012-06-01 17:45:13 UTC) #3
kochi
Thanks for the reviews! http://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js File chrome/browser/resources/options2/language_options.js (left): http://chromiumcodereview.appspot.com/10442128/diff/1/chrome/browser/resources/options2/language_options.js#oldcode116 chrome/browser/resources/options2/language_options.js:116: chrome.send.bind(chrome, 'uiLanguageRestart'); On 2012/06/01 17:21:17, ...
8 years, 6 months ago (2012-06-02 22:39:14 UTC) #4
Dan Beam
http://codereview.chromium.org/10442128/diff/7001/chrome/browser/resources/options2/language_options.js File chrome/browser/resources/options2/language_options.js (right): http://codereview.chromium.org/10442128/diff/7001/chrome/browser/resources/options2/language_options.js#newcode124 chrome/browser/resources/options2/language_options.js:124: chrome.send('uiLanguageRestart'); this calls the function, doesn't return a reference ...
8 years, 6 months ago (2012-06-12 01:28:28 UTC) #5
kochi
Hi Dan, thanks for the comments. (I was also OOO last week). I'm still not ...
8 years, 6 months ago (2012-06-12 06:02:25 UTC) #6
Dan Beam
lgtm my only thoughts to why this wasn't working would be that the "chrome" object ...
8 years, 6 months ago (2012-06-12 06:09:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10442128/11001
8 years, 6 months ago (2012-06-12 06:25:26 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 08:46:25 UTC) #9
Change committed as 141632

Powered by Google App Engine
This is Rietveld 408576698