Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: dart/lib/compiler/implementation/ssa/builder.dart

Issue 10442107: Implement super read. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update status files Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/ssa/builder.dart
diff --git a/dart/lib/compiler/implementation/ssa/builder.dart b/dart/lib/compiler/implementation/ssa/builder.dart
index 5240135f5863c479e95946a0f10d3bb2d6ec23b1..51d07b6171f14041e40b472cd2d7b2695183eeaf 100644
--- a/dart/lib/compiler/implementation/ssa/builder.dart
+++ b/dart/lib/compiler/implementation/ssa/builder.dart
@@ -2290,8 +2290,10 @@ class SsaBuilder implements Visitor {
HInstruction context = localsHandler.readThis();
add(target);
var inputs = <HInstruction>[target, context];
- if (element.kind == ElementKind.FUNCTION ||
- element.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
+ if (node.isPropertyAccess) {
+ push(new HInvokeSuper(selector, inputs));
+ } else if (element.kind == ElementKind.FUNCTION ||
+ element.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
bool succeeded = addStaticSendArgumentsToList(selector, node.arguments,
element, inputs);
if (!succeeded) {
@@ -2398,9 +2400,6 @@ class SsaBuilder implements Visitor {
visitSend(Send node) {
if (node.isSuperCall) {
- if (node.isPropertyAccess) {
- compiler.unimplemented('super property read', node: node);
- }
visitSuperSend(node);
} else if (node.isOperator && methodInterceptionEnabled) {
visitOperatorSend(node);
« no previous file with comments | « no previous file | dart/lib/compiler/implementation/ssa/codegen.dart » ('j') | dart/lib/compiler/implementation/ssa/codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698