Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 10442072: Move ParamTraits<base::PlatformFileInfo> and <base::PlatformFileError>. (Closed)

Created:
8 years, 6 months ago by Tom Sepez
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Move ParamTraits<base::PlatformFileInfo> and <base::PlatformFileError>. Move thse to ipc/ from content/common so that they may be used in directories parallel to content/. Pre-requisite for fixing the associated bug. BUG=127624 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139636

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M content/public/common/common_param_traits.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M content/public/common/common_param_traits.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Hi John, This is the change I email'ed you about on Friday. Please review.
8 years, 6 months ago (2012-05-29 20:24:18 UTC) #1
jam
lgtm
8 years, 6 months ago (2012-05-29 21:48:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/10442072/6001
8 years, 6 months ago (2012-05-29 21:52:12 UTC) #3
commit-bot: I haz the power
Try job failure for 10442072-6001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-05-29 22:50:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/10442072/1009
8 years, 6 months ago (2012-05-30 18:48:45 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 21:16:03 UTC) #6
Change committed as 139636

Powered by Google App Engine
This is Rietveld 408576698