Issue 10442068: Add more consitent exception generation and handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10442068: Add more consitent exception generation and handling (Closed)

Created:
8 years, 6 months ago by M-A Ruel

Modified:
8 years, 6 months ago

Reviewers:
cmp, MAD

CC:
chromium-reviews, pam+watch_chromium.org, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more consistent exception generation and handling Convert many assert into proper exceptions. This makes the code more usable as a library. This is important as tracing in some case will fail, e.g. with strace race conditions, so they need to be handled properly. NOTRY=true R=cmp@chromium.org BUG=98636 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140427

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Narrow exception handling in trace_test_cases.py #

Patch Set 4 : Rebase #

Patch Set 5 : fix small bug #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+411 lines, -199 lines)			Patch
M	tools/isolate/trace_inputs.py	View	1 2 3 4	32 chunks	+400 lines, -195 lines	0 comments	Download
M	tools/isolate/trace_inputs_test.py	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download
M	tools/isolate/trace_test_cases.py	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cmp

title says 'add more consitent' should be 'add more consistent'

8 years, 6 months ago (2012-06-04 22:27:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10442068/10001

8 years, 6 months ago (2012-06-04 23:32:57 UTC) #4

Change committed as 140427

Expand Messages | Collapse Messages