Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 10442063: Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical spa… (Closed)

Created:
8 years, 6 months ago by apavlov
Modified:
8 years, 6 months ago
Reviewers:
apavlov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space https://bugs.webkit.org/show_bug.cgi?id=87735 Reviewed by Kent Tamura. This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418. No new tests, as popups are not testable in Chromium. * platform/chromium/PopupContainer.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M Source/WebCore/platform/chromium/PopupContainer.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
8 years, 6 months ago (2012-05-29 14:06:01 UTC) #1
apavlov
8 years, 6 months ago (2012-05-29 14:09:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698