Issue 10442063: Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical spa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10442063: Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical spa… (Closed)

Created:
8 years, 6 months ago by apavlov

Modified:
8 years, 6 months ago

Reviewers:
apavlov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Visibility:
Public.

More Reviews

Description

Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space https://bugs.webkit.org/show_bug.cgi?id=87735 Reviewed by Kent Tamura. This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418. No new tests, as popups are not testable in Chromium. * platform/chromium/PopupContainer.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): TBR=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118773

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	Source/WebCore/platform/chromium/PopupContainer.cpp	View		1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages