Native wrappers should implement dart:html interfaces.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 337 matching lines @@
         '\n'
         '  $EVENTS_CLASS get on() {\n'
         '    if (_on === null) _on = new $EVENTS_CLASS(this);\n'
         '    return _on;\n'
         '  }\n',
         EVENTS_CLASS=events_class)
 
   def _ImplClassName(self, interface_name):
     return '_%sDOMImpl' % interface_name
 
   def _DartType(self, idl_type):

[Anton Muhin, 2012/05/30 00:10:46]

do we need this method at all?

-    # FIXME: Make dart:html wrapperless and cleanup this method.
-    if idl_type in ['EventListener', 'TimeoutHandler']:
-      return idl_type
-    if idl_type in ['EventTarget', 'IDBAny', 'IDBKey']:
-      return 'Dynamic'
-    if idl_type == 'DOMStringList':
-      return 'List<String>'
-
     type_info = GetIDLTypeInfo(idl_type)
-    if isinstance(type_info, PrimitiveIDLTypeInfo) or isinstance(type_info, SequenceIDLTypeInfo):
-      return type_info.dart_type()
-
-    if self._system._database.HasInterface(idl_type):
-      interface = self._system._database.GetInterface(idl_type)
-      if 'Callback' in interface.ext_attrs:
-        return idl_type
-      return '_%s' % idl_type
-    return idl_type
+    return self._HTMLInterfaceName(type_info.dart_type())

[Anton Muhin, 2012/05/30 00:10:46]

nit: make a one-liner?

 
   def _BaseClassName(self):
     if not self._interface.parents:
       return '_DOMWrapperBase'
 
     supertype = self._interface.parents[0].type.id
 
     # FIXME: We're currently injecting List<..> and EventTarget as
     # supertypes in dart.idl. We should annotate/preserve as
     # attributes instead.  For now, this hack lets the self._interfaces
@@ skipping 42 matching lines @@
         IMPL_CLASS=implementation_class,
         TYPE=self._ImplClassName(interface_name),
         IMPL_FUNCTION=implementation_function,
         NATIVE_NAME=native_implementation_function)
 
   def FinishInterface(self):
     class_name = self._ImplClassName(self._interface.id)
     base = self._BaseClassName()
     self._dart_impl_emitter.Emit(
         self._templates.Load('dart_implementation.darttemplate'),
-        CLASS=class_name, BASE=base, INTERFACE=self._interface.id,
+        CLASS=class_name,
+        BASE=base,
+        INTERFACE=self._interface.id,
+        HTML_INTERFACE=self._HTMLInterfaceName(self._interface.id),
         MEMBERS=self._members_emitter.Fragments())
 
     self._GenerateCppHeader()
 
     self._cpp_impl_emitter.Emit(
         self._templates.Load('cpp_implementation.template'),
         INTERFACE=self._interface.id,
         INCLUDES=_GenerateCPPIncludes(self._cpp_impl_includes),
         CALLBACKS=self._cpp_definitions_emitter.Fragments(),
         RESOLVER=self._cpp_resolver_emitter.Fragments(),
@@ skipping 796 matching lines @@
   for parent in interface.parents:
     parent_name = parent.type.id
     if not database.HasInterface(parent.type.id):
       continue
     parent_interface = database.GetInterface(parent.type.id)
     if callback(parent_interface):
       return parent_interface
     parent_interface = _FindParent(parent_interface, database, callback)
     if parent_interface:
       return parent_interface