Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8445)

Unified Diff: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

Issue 10442044: Fix the white flicker of the keyboard overlay when it first appearing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
diff --git a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
index 1d682b05b068d11ebd7b7aa346bed4c0f6250a7f..4456cdd43230d4242d9e6c4e695565bcbda51b2e 100644
--- a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
+++ b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
@@ -50,25 +50,7 @@ void KeyboardOverlayDialogView::ShowDialog() {
l10n_util::GetStringUTF16(IDS_KEYBOARD_OVERLAY_TITLE));
KeyboardOverlayDialogView* view = new KeyboardOverlayDialogView(
ProfileManager::GetDefaultProfileOrOffTheRecord(), delegate);
- delegate->set_view(view);
-
- views::Widget* widget = new views::Widget;
- views::Widget::InitParams params(
- views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
- params.delegate = view;
- widget->Init(params);
-
- // Show the widget at the bottom of the work area.
- gfx::Size size;
- delegate->GetDialogSize(&size);
- gfx::Rect rect = gfx::Screen::GetMonitorNearestWindow(
- view->GetWidget()->GetNativeView()).work_area();
- gfx::Rect bounds((rect.width() - size.width()) / 2,
- rect.height() - size.height(),
- size.width(),
- size.height());
- view->GetWidget()->SetBounds(bounds);
- view->GetWidget()->Show();
+ delegate->Show(view);
g_instance = view;
}
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698