Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Side by Side Diff: src/arm/ic-arm.cc

Issue 10442015: Rollback of r11638, r11636 on trunk branch. (Closed) Base URL: https://v8.googlecode.com/svn/trunk
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1231 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 1242
1243 void KeyedStoreIC::GenerateTransitionElementsSmiToDouble(MacroAssembler* masm) { 1243 void KeyedStoreIC::GenerateTransitionElementsSmiToDouble(MacroAssembler* masm) {
1244 // ---------- S t a t e -------------- 1244 // ---------- S t a t e --------------
1245 // -- r2 : receiver 1245 // -- r2 : receiver
1246 // -- r3 : target map 1246 // -- r3 : target map
1247 // -- lr : return address 1247 // -- lr : return address
1248 // ----------------------------------- 1248 // -----------------------------------
1249 // Must return the modified receiver in r0. 1249 // Must return the modified receiver in r0.
1250 if (!FLAG_trace_elements_transitions) { 1250 if (!FLAG_trace_elements_transitions) {
1251 Label fail; 1251 Label fail;
1252 ElementsTransitionGenerator::GenerateSmiToDouble(masm, &fail); 1252 ElementsTransitionGenerator::GenerateSmiOnlyToDouble(masm, &fail);
1253 __ mov(r0, r2); 1253 __ mov(r0, r2);
1254 __ Ret(); 1254 __ Ret();
1255 __ bind(&fail); 1255 __ bind(&fail);
1256 } 1256 }
1257 1257
1258 __ push(r2); 1258 __ push(r2);
1259 __ TailCallRuntime(Runtime::kTransitionElementsSmiToDouble, 1, 1); 1259 __ TailCallRuntime(Runtime::kTransitionElementsSmiToDouble, 1, 1);
1260 } 1260 }
1261 1261
1262 1262
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
1455 r6, 1455 r6,
1456 &transition_double_elements); 1456 &transition_double_elements);
1457 __ Ret(); 1457 __ Ret();
1458 1458
1459 __ bind(&transition_smi_elements); 1459 __ bind(&transition_smi_elements);
1460 // Transition the array appropriately depending on the value type. 1460 // Transition the array appropriately depending on the value type.
1461 __ ldr(r4, FieldMemOperand(value, HeapObject::kMapOffset)); 1461 __ ldr(r4, FieldMemOperand(value, HeapObject::kMapOffset));
1462 __ CompareRoot(r4, Heap::kHeapNumberMapRootIndex); 1462 __ CompareRoot(r4, Heap::kHeapNumberMapRootIndex);
1463 __ b(ne, &non_double_value); 1463 __ b(ne, &non_double_value);
1464 1464
1465 // Value is a double. Transition FAST_SMI_ELEMENTS -> 1465 // Value is a double. Transition FAST_SMI_ONLY_ELEMENTS ->
1466 // FAST_DOUBLE_ELEMENTS and complete the store. 1466 // FAST_DOUBLE_ELEMENTS and complete the store.
1467 __ LoadTransitionedArrayMapConditional(FAST_SMI_ELEMENTS, 1467 __ LoadTransitionedArrayMapConditional(FAST_SMI_ONLY_ELEMENTS,
1468 FAST_DOUBLE_ELEMENTS, 1468 FAST_DOUBLE_ELEMENTS,
1469 receiver_map, 1469 receiver_map,
1470 r4, 1470 r4,
1471 &slow); 1471 &slow);
1472 ASSERT(receiver_map.is(r3)); // Transition code expects map in r3 1472 ASSERT(receiver_map.is(r3)); // Transition code expects map in r3
1473 ElementsTransitionGenerator::GenerateSmiToDouble(masm, &slow); 1473 ElementsTransitionGenerator::GenerateSmiOnlyToDouble(masm, &slow);
1474 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset)); 1474 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
1475 __ jmp(&fast_double_without_map_check); 1475 __ jmp(&fast_double_without_map_check);
1476 1476
1477 __ bind(&non_double_value); 1477 __ bind(&non_double_value);
1478 // Value is not a double, FAST_SMI_ELEMENTS -> FAST_ELEMENTS 1478 // Value is not a double, FAST_SMI_ONLY_ELEMENTS -> FAST_ELEMENTS
1479 __ LoadTransitionedArrayMapConditional(FAST_SMI_ELEMENTS, 1479 __ LoadTransitionedArrayMapConditional(FAST_SMI_ONLY_ELEMENTS,
1480 FAST_ELEMENTS, 1480 FAST_ELEMENTS,
1481 receiver_map, 1481 receiver_map,
1482 r4, 1482 r4,
1483 &slow); 1483 &slow);
1484 ASSERT(receiver_map.is(r3)); // Transition code expects map in r3 1484 ASSERT(receiver_map.is(r3)); // Transition code expects map in r3
1485 ElementsTransitionGenerator::GenerateMapChangeElementsTransition(masm); 1485 ElementsTransitionGenerator::GenerateSmiOnlyToObject(masm);
1486 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset)); 1486 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
1487 __ jmp(&finish_object_store); 1487 __ jmp(&finish_object_store);
1488 1488
1489 __ bind(&transition_double_elements); 1489 __ bind(&transition_double_elements);
1490 // Elements are FAST_DOUBLE_ELEMENTS, but value is an Object that's not a 1490 // Elements are FAST_DOUBLE_ELEMENTS, but value is an Object that's not a
1491 // HeapNumber. Make sure that the receiver is a Array with FAST_ELEMENTS and 1491 // HeapNumber. Make sure that the receiver is a Array with FAST_ELEMENTS and
1492 // transition array from FAST_DOUBLE_ELEMENTS to FAST_ELEMENTS 1492 // transition array from FAST_DOUBLE_ELEMENTS to FAST_ELEMENTS
1493 __ LoadTransitionedArrayMapConditional(FAST_DOUBLE_ELEMENTS, 1493 __ LoadTransitionedArrayMapConditional(FAST_DOUBLE_ELEMENTS,
1494 FAST_ELEMENTS, 1494 FAST_ELEMENTS,
1495 receiver_map, 1495 receiver_map,
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
1755 } else { 1755 } else {
1756 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1756 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1757 patcher.EmitCondition(eq); 1757 patcher.EmitCondition(eq);
1758 } 1758 }
1759 } 1759 }
1760 1760
1761 1761
1762 } } // namespace v8::internal 1762 } } // namespace v8::internal
1763 1763
1764 #endif // V8_TARGET_ARCH_ARM 1764 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698