[Chromoting] Handle CR-LF correctly when transferring text items to and from the clipboard on a Win…

remoting/base/util_unittest.cc

Index: remoting/base/util_unittest.cc
diff --git a/remoting/base/util_unittest.cc b/remoting/base/util_unittest.cc
index 24e628daf19064d66e36df7391626a4609dbda28..19579776584eeb1216bfdf7c0908aefb906675fd 100644
--- a/remoting/base/util_unittest.cc
+++ b/remoting/base/util_unittest.cc
@@ -184,4 +184,73 @@ TEST(YuvToRgbTest, ClippingAndScaling) {
   }
 }
 
+TEST(ReplaceLfByCrLfTest, Basic) {
+  EXPECT_EQ("ab", ReplaceLfByCrLf("ab"));
+  EXPECT_EQ("\r\nab", ReplaceLfByCrLf("\nab"));
+  EXPECT_EQ("\r\nab\r\n", ReplaceLfByCrLf("\nab\n"));
+  EXPECT_EQ("\r\nab\r\ncd", ReplaceLfByCrLf("\nab\ncd"));
+  EXPECT_EQ("\r\nab\r\ncd\r\n", ReplaceLfByCrLf("\nab\ncd\n"));
+  EXPECT_EQ("\r\n\r\nab\r\n\r\ncd\r\n\r\n",
+      ReplaceLfByCrLf("\n\nab\n\ncd\n\n"));
+}
+
+TEST(ReplaceLfByCrLfTest, Speed) {
+  int kLineSize = 128;
+  std::string line(kLineSize, 'a');
+  line[kLineSize - 1] = '\n';
+  // Make a 10M string.
+  int kLineNum = 10 * 1024 * 1024 / kLineSize;
+  std::string buffer;
+  buffer.resize(kLineNum * kLineSize);
+  for (int i = 0; i < kLineNum; ++i) {
+    memcpy(&buffer[i * kLineSize], &line[0], kLineSize);
+  }
+  // Convert the string.
+  buffer = ReplaceLfByCrLf(buffer);
+  // Check the converted string.
+  EXPECT_EQ(static_cast<size_t>((kLineSize + 1) * kLineNum), buffer.size());
+  const char* p = &buffer[0];
+  for (int i = 0; i < kLineNum; ++i) {
+    EXPECT_EQ(0, memcmp(&line[0], p, kLineSize - 1));
+    p += kLineSize - 1;
+    EXPECT_EQ('\r', *p++);
+    EXPECT_EQ('\n', *p++);
+  }
+}
+
+TEST(ReplaceCrLfByLfTest, Basic) {
+  EXPECT_EQ("ab", ReplaceCrLfByLf("ab"));
+  EXPECT_EQ("\nab", ReplaceCrLfByLf("\r\nab"));
+  EXPECT_EQ("\nab\n", ReplaceCrLfByLf("\r\nab\r\n"));
+  EXPECT_EQ("\nab\ncd", ReplaceCrLfByLf("\r\nab\r\ncd"));
+  EXPECT_EQ("\nab\ncd\n", ReplaceCrLfByLf("\r\nab\r\ncd\n"));
+  EXPECT_EQ("\n\nab\n\ncd\n\n",
+      ReplaceCrLfByLf("\r\n\r\nab\r\n\r\ncd\r\n\r\n"));
+  EXPECT_EQ("\rab\rcd\r", ReplaceCrLfByLf("\rab\rcd\r"));
+}
+
+TEST(ReplaceCrLfByLfTest, Speed) {
+  int kLineSize = 128;
+  std::string line(kLineSize, 'a');
+  line[kLineSize - 2] = '\r';
+  line[kLineSize - 1] = '\n';
+  // Make a 10M string.
+  int kLineNum = 10 * 1024 * 1024 / kLineSize;
+  std::string buffer;
+  buffer.resize(kLineNum * kLineSize);
+  for (int i = 0; i < kLineNum; ++i) {
+    memcpy(&buffer[i * kLineSize], &line[0], kLineSize);
+  }
+  // Convert the string.
+  buffer = ReplaceCrLfByLf(buffer);
+  // Check the converted string.
+  EXPECT_EQ(static_cast<size_t>((kLineSize - 1) * kLineNum), buffer.size());
+  const char* p = &buffer[0];
+  for (int i = 0; i < kLineNum; ++i) {
+    EXPECT_EQ(0, memcmp(&line[0], p, kLineSize - 2));
+    p += kLineSize - 2;
+    EXPECT_EQ('\n', *p++);
+  }
+}
+
 }  // namespace remoting